Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add debugging and commit signing instructions to CONTRIBUTING.md #109

Merged
merged 4 commits into from
Nov 28, 2023
Merged

Add debugging and commit signing instructions to CONTRIBUTING.md #109

merged 4 commits into from
Nov 28, 2023

Conversation

williamhpark
Copy link
Contributor

@williamhpark williamhpark commented Nov 28, 2023 •
edited
Loading

Summary

Updates made to the CONTIBUTING.md file:

  1. Added a 'Debugging' section with instructions on how to start a debugging session.
  2. Added a 'Sign Your Commits' section, instructing that commits need to be signed and linking to the 1Password 'Git commit signing with SSH' documentation. This section was copied from the shell plugins CONTRIBUTING.md file.
  3. Changed the wording from "plugin" to "provider" in certain sections.
  4. Kept all headings consistent with title casing.

@volodymyrZotov volodymyrZotov merged commit 74b390e into update-documentation-with-service-accounts Nov 28, 2023
4 checks passed
@volodymyrZotov volodymyrZotov deleted the wpark/update-contributing-docs branch November 28, 2023 22:58
@edif2008 edif2008 mentioned this pull request Nov 29, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@volodymyrZotov volodymyrZotov volodymyrZotov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@williamhpark @volodymyrZotov